search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
138 stars 50 forks source link

ADD Auto test #24

Closed andrewjaykeller closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 90.53%

Branch #24 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found. Review entire Coverage Diff as of 9984925

Powered by Codecov. Updated on successful CI builds.

teonbrooks commented 8 years ago

this was such a massive code dump ;) I made it through it. are you going to add the option for the data to be streamed as both float and binary (byte packets)? if not, what is the fidelity of the data being converted back to the binary? I know you have a test of it but what is the tolerance or the difference from the original binary and the binary to float to binary conversion?

teonbrooks commented 8 years ago

btw, the git history is fine. it wouldn't be a problem with merging. my plans for OpenEXP is to create an EEG writer, which takes an n_channels x n_samples and writes it to EDF (loss of resolution from 24-bit to 16-bit) or BDF (24-bit).

andrewjaykeller commented 8 years ago

not sure what happened!

teonbrooks commented 8 years ago

LGTM, ready for me to merge it?

teonbrooks commented 8 years ago

thanks @pushtheworldllc!

andrewjaykeller commented 8 years ago

Thanks @teonlamont for your code review and insights!