search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
138 stars 50 forks source link

0.3.0 - ENH Continuous Impedance Testing ADD NTP features #32

Closed andrewjaykeller closed 8 years ago

andrewjaykeller commented 8 years ago

Should be just about done.

codecov-io commented 8 years ago

Current coverage is 85.36%

Merging #32 into master will decrease coverage by -5.17% as of 6eca315

@@            master     #32   diff @@
======================================
  Files            4       4       
  Stmts         1067    1257   +190
  Branches       136     156    +20
  Methods          0       0       
======================================
+ Hit            966    1073   +107
- Partial          1       4     +3
- Missed         100     180    +80

Review entire Coverage Diff as of 6eca315

Powered by Codecov. Updated on successful CI builds.

teonbrooks commented 8 years ago

this has NTP? is this that surprise PR you were talking about ;)

teonbrooks commented 8 years ago

this should have been at two PRs :sob:

andrewjaykeller commented 8 years ago

Sorry you guys said to not update it for a month so I've had all these updates just building up haha

andrewjaykeller commented 8 years ago

@teonbrooks next time the little fixes will be patches and not bundled into one big update... Sorry!

teonbrooks commented 8 years ago

let me know when it's ready for ready. it might have to wait til Saturday for a thorough sit down. did you get the invite to work IRL?

andrewjaykeller commented 8 years ago

Ok. Man i really think as soon as we get this new firmware up and running all these impedance issues will disappear. I'm down to work on this in person this Saturday.

teonbrooks commented 8 years ago

geezus, I just finished. I will make another issue for ntp. It seems like it should be good. Is it only implemented for the simulator though?

andrewjaykeller commented 8 years ago

So the simulator is really just about ready for testing with the firmware that is still being written for the board, so I am working on the firmware for the board and as soon as that is working we can use all the functions here to make the time syncing really work!

andrewjaykeller commented 8 years ago

Definitely make another issue for ntp though!

andrewjaykeller commented 8 years ago

@teonbrooks any outstanding matters?

andrewjaykeller commented 8 years ago

You know your PR is too damn big when you hit over 100 messages in the conversation

teonbrooks commented 8 years ago

I am satisfied now. great work @pushtheworldllc!! merging

andrewheusser commented 8 years ago

damn! you guys crushed this. Thanks @pushtheworldllc and @teonbrooks you rockkkkkkk