search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
138 stars 50 forks source link

ENH/ADD sntp time sync methods #45

Closed andrewjaykeller closed 8 years ago

andrewjaykeller commented 8 years ago

I added a key function for SNTP, called .sntpNow() I also simply extended sntp class so we could call into that if need by in the future.

teonbrooks commented 8 years ago

LGTM. just curious, have you tested this code yet on real data? this is useful to syncing the board to time server, does this mean we need to instruct computer-side app to implement a similar protocol when the computer is connected to the internet?

andrewjaykeller commented 8 years ago

No! The firmware has not been implemented yet!! These are the functions that are required to talk with the board though!

andrewjaykeller commented 8 years ago

Firmware is happening by next Thursday

andrewjaykeller commented 8 years ago

So you will see another PR come thru soon that adds V4 functionality

teonbrooks commented 8 years ago

v4 of the firmware? i know that the board has v3 printed on that, but I am assuming that this is just the 3rd iteration of the board design. that is separate from the board's firmware, do you know?

andrewjaykeller commented 8 years ago

oh shit true, lol can we merge this and discuss how i have been calling my software update the wrong thing in another form haha

teonbrooks commented 8 years ago

sure, merging now. feel free to make an issue about the name