openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
138 stars 50 forks source link

ENH simulator looking more brain like #56

Closed andrewjaykeller closed 8 years ago

andrewjaykeller commented 8 years ago

Simulator is looking more brainy then it ever has!

codecov-io commented 8 years ago

Current coverage is 84.68%

Merging #56 into master will increase coverage by -15.32%

  1. File openBCISample.js was modified. more
    • Misses +30
    • Partials 0
    • Hits -260
  2. File openBCISimulator.js was modified. more
    • Misses +26
    • Partials 0
    • Hits -96
  3. File openBCIConstants.js was modified. more
    • Misses +72
    • Partials 0
    • Hits -380
  4. File openBCIBoard.js was modified. more
    • Misses +80
    • Partials 0
    • Hits -835
@@             master        #56   diff @@
==========================================
  Files             4          4           
  Lines          2814       1384   -1430   
  Methods          97         97           
  Messages          0          0           
  Branches        467        260    -207   
==========================================
- Hits           2814       1172   -1642   
- Misses            0        212    +212   
  Partials          0          0           

Powered by Codecov. Last updated by 8aa69a1...7711c84

alexcastillo commented 8 years ago

This is looking great. Can we merge it @pushtheworldllc ?

andrewjaykeller commented 8 years ago

Did you review the code? Just need someone to +1 it

alexcastillo commented 8 years ago

Yes, everything looks great. Go for it!