search

openbci-archive / OpenBCI_Python

The Python software library designed to work with OpenBCI hardware.
MIT License
510 stars 207 forks source link

fixing importing scheme for plugins to address #91 #121

Open rivasd opened 5 years ago

rivasd commented 5 years ago

This should fix #91 that is still not working in 1.0.2 by moving plugin_interface inside the plugins folder and fixing importing syntax accordingly

codecov-io commented 5 years ago

Codecov Report

Merging #121 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   37.46%   37.46%           
=======================================
  Files           9        9           
  Lines        1588     1588           
=======================================
  Hits          595      595           
  Misses        993      993

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2288eb...3da8042. Read the comment docs.

daniellasry commented 5 years ago

Our python developer, @andreaortuno , is currently working on removing the yapsy plugin manager. Instead, we'll have simple Cyton & Ganglion classes with the same functions.

In the interim, this fix is definitely welcome. I will test it out shortly.