search

openbibleinfo / Bible-Passage-Reference-Parser

Coffeescript to identify and understand Bible references like "John 3:16."
223 stars 65 forks source link

Use npm for dependencies & scripts and update German data.txt #40

Open renehamburger opened 6 years ago

renehamburger commented 6 years ago

In an initial commit, I've added all NodeJS dependencies to the package.json. This simplifies the process significantly, as all dependencies are explicit (except for perl and its JSON module) and installed with a single command. In the same commit I've added npm scripts for the 2 build steps and for running tests. They are somewhat cleaner and more accessible than the perl scripts and the previously documented test script did not exist!

In the second commit I added a Jasmine matcher string to most expectations, which is printed out when an expectation fails. This was necessary to debug pegjs expressions that were initially failing in the next step.

The two subsequent commits make several improvements to the German data.txt and add all generated de files for these changes. I have not build the full or ascii version yet.

renehamburger commented 6 years ago

@openbibleinfo, are you able to look at this PR at some stage? If you're struggling to find the time, I'm happy to continue in my forked repo.

alerque commented 6 years ago

@renehamburger (and CC @openbibleinfo) I've been really frustrated in the past trying to contribute to development on this project. Stephan I really appreciate the code and fact that you've allowed the world to use it. It's really well done and serves me (and the Bible related projects I make for other's use) well. This is in no way meant to knock you — I'm just saying that the project management methodology could really use some help. The practice of developing on your own somewhere and integrating changes through whatever workflow you use locally then posting only final releases as commits to this project makes it VERY difficult for outside contributors like myself. We can't tell easily what changes we made are even included or not included, we can't rebase our local modifications for special purposes very easily, and we get no insight into the development process and what would be useful or not.

Can I respectfully request you consider changing up the workflow so you actually make incremental changes in the git repository, accept contributions (or reject them) based on PR's and the code review process here, integrate them via merges so the project history actually shows who did what when and why, and then tag releases when they are ready? Pretty please?

renehamburger commented 6 years ago

Thanks for your contribution, @alerque!

If @openbibleinfo does not have the time any more to continue maintaining this repository or if he would prefer to keep everything as is, I'd be happy to continue in my fork.

I would like to continue improving the test coverage and the build system. I've already linked it to TravisCI both for continuous testing of commits and pull requests and for automatic building of the dependent files.