openbikesensor / OpenBikeSensorFirmware

Overtaking distance measurements for cyclists
https://www.openbikesensor.org/
GNU Lesser General Public License v3.0
110 stars 25 forks source link

Verify server certificates against the full Mozilla trust store #365

Closed schiermi closed 1 month ago

schiermi commented 4 months ago

A build containing those changes was tested for three weeks "on the bike". Testing included track uploads, OBS webinterface access & ALP data downloads.

This PR increases the compiled firmware size by ~60 kb.

_It should be beneficial to include the instructions found in src/truststore/README.md to update the binary trust store src/truststore/x509_crt_bundle into the Github actions pipeline for new builds, but I'm missing knowledge for this task._

amandel commented 4 months ago

I can add the steps to the Github actions build. I hope to fine the time to do this as well as building the pro & classic code in one go. If I don't find the time till near next release we merge it as is :)

schiermi commented 1 month ago
amandel commented 1 month ago

Great to have the certs update integrated in the build!

The CI build now fails giving:

Traceback (most recent call last):
The cryptography package is not installed.Please refer to the Get Started section of the ESP-IDF Programming Guide for setting up the required packages.
  File "/__w/OpenBikeSensorFirmware/OpenBikeSensorFirmware/src/truststore/gen_crt_bundle.py", line 36, in <module>
    from cryptography import x509
ModuleNotFoundError: No module named 'cryptography'
Error: Process completed with exit code 1.
schiermi commented 1 month ago

Slowly getting my feet wet with GH actions; looks better now: image

https://github.com/schiermi/OpenBikeSensorFirmware/actions/runs/10874202448/job/30171220169