search

openbikesensor / openbikesensor.github.io

The OpenBikeSensor project website and documentation
https://openbikesensor.org
GNU Lesser General Public License v3.0
26 stars 33 forks source link

English pages #158

Closed Steglitz closed 2 years ago

Steglitz commented 2 years ago

I added a missing English page and made some readability edits elsewhere.

SubOptimal commented 2 years ago

An English translation of file content/verein.de.md is required by content/contact/_index.en.md.

SubOptimal commented 2 years ago

A more general note: Please keep the lines short. It makes the process for the reviewer a bit easier.

Steglitz commented 2 years ago

I have a version of verein.en.md prepared for a future pull request. I just want to resolve my initial requests so I can work from one branch with the latest updates. Future pull requests will have more substantial code changes instead of many small edits.

Steglitz commented 2 years ago

A more general note: Please keep the lines short. It makes the process for the reviewer a bit easier.

Do you mean the code lines themselves? I've tried to add some hard wrapping but missed some lines due to the soft wrapping setting in my editor. I'll try to keep things shorter if possible.

SubOptimal commented 2 years ago

I have a version of verein.en.md prepared for a future pull request. I just want to resolve my initial requests so I can work from one branch with the latest updates. Future pull requests will have more substantial code changes instead of many small edits.

Without the file content/verein.en.md hugo will not build the page. So it should be part of this pull request.

REF_NOT_FOUND: Ref "verein": ".../openbikesensor.github.io/content/contact/_index.en.md:31:52": page not found
Steglitz commented 2 years ago

I have a version of verein.en.md prepared for a future pull request. I just want to resolve my initial requests so I can work from one branch with the latest updates. Future pull requests will have more substantial code changes instead of many small edits.

Without the file content/verein.en.md hugo will not build the page. So it should be part of this pull request.

REF_NOT_FOUND: Ref "verein": ".../openbikesensor.github.io/content/contact/_index.en.md:31:52": page not found

Excellent. I'll take care of that next then.

SubOptimal commented 2 years ago

Do you mean the code lines themselves?

Yes. It's hard to see which parts were added or changed and which remain unchanged, especially on now concatenated lines.

https://github.com/openbikesensor/openbikesensor.github.io/pull/158/files

Steglitz commented 2 years ago

Ok. I'll watch out for that then. Thank you for the advice.

Steglitz commented 2 years ago

I needed some of the pages from this pull request to finish the changes for patch-4, so I merged them into patch-4.

Steglitz commented 2 years ago

I'm closing this request as my changes have been merged into patch-4. I'll begin work on my next changes while I wait for the review on that branch.