search

openbikesensor / openbikesensor.github.io

The OpenBikeSensor project website and documentation
https://openbikesensor.org
GNU Lesser General Public License v3.0
28 stars 32 forks source link

Replace "Ideal Image Slider" #43

Open M-a-r-i-a-n-n-e opened 3 years ago

M-a-r-i-a-n-n-e commented 3 years ago

Using the "alt" attribute for Ideal Image Slider leads to double captions (once a caption then the same text again) on images. The "title" attribute does not seem to work.

This comes from a code that is no longer maintained and was copied from this repo to iis-captions.js von assets/js/slider.

captionContent += '<div class="iis-caption-title">' + slide.getAttribute('title') + '</div>';

@opatut what should we do about it? Just commenting this line would fix the problem of duplicate titles, but using copy of a library that is unsupported since 2015 might involve other risks, too.

opatut commented 3 years ago

Well I only used the slider because it was used by the previous jekyll plugin. I didn't mind using it again, I like the way it works in the end. I think we can just hack around in it, if it is unmaintained then at least we won't have to update it :joy: On the other hand, if you want to replace it entirely with something else, that's fine for me as well. I just don't think the effort is worth it right now.

If you hack on this anyway, can you take care that the alt attribute on the images are set correctly, even if you switch to a different attribute (title) for setting the caption contents?

M-a-r-i-a-n-n-e commented 3 years ago

I would prefer to throw it out.. I'm just looking into carousel, which already seems to be in the workspace.

opatut commented 3 years ago

If you want to do that, go ahead! As long as it doesn't involve jQuery ;)

Oh, and if you do, please take care of the print view as well, the images have to print sequentially with captions, because that's used quite often to print out instructions.

M-a-r-i-a-n-n-e commented 3 years ago

Good point! Maybe we fix this one line first by a workaround (see pull request #44 ) and take our time for including and testing an alternative.