Allow overriding some more Makefile variables

openbios / fcode-utils

A set of utilities to process FCODE, OpenFirmware's byte code

https://www.openfirmware.info/FCODE_suite

GNU General Public License v2.0

29 stars 12 forks source link

Allow overriding some more Makefile variables #16

Closed lemenkov closed 4 months ago

lemenkov commented 5 months ago

This PR lets anyone to override a few extra variables

DESTDIR can be set to anything ( /usr for example or any $BUILDROOT/usr)
STRIP can be set to /bin/true to avoid stripping of debug symbols
CFLAGS can be set to any preferred value (at your own risk)

Fixes #15.

mcayland commented 4 months ago

Thanks! This looks good to me, so I've merged it.

emixa-d commented 4 months ago

This does not fix #15! This PR only allows overriding DESTDIR (and STRIP and CFLAGS, but that has nothing to do with #15). It still uses DESTDIR and PREFIX incorrectly. Please read the things I linked to in #15 (here's an updated link, as one of them appears to be broken):

https://people.freebsd.org/~olivierd/porters-handbook/porting-prefix.html#:~:text=PREFIX%20determines%20where%20the%20port,the%20value%20of%20this%20variable.