search

openbios / fcode-utils

A set of utilities to process FCODE, OpenFirmware's byte code
https://www.openfirmware.info/FCODE_suite
GNU General Public License v2.0
29 stars 12 forks source link

Add basic EFI romheaders support #5

Open zajdee opened 6 years ago

zajdee commented 6 years ago

This commit adds a very basic EFI romheaders support. It also prints a short comment on code type 0xff, which is being used by iPXE.

mcayland commented 5 years ago

Thanks for the patch! I've had a look at this and the preparatory cleanup work in patches 1-3 seems good to me.

From what I can see of patch 4 it also seems reasonable, however the formatting style e.g. braces around for() loops etc. doesn't seem to match that of the existing code. Can you repush with the formatting corrected?

Finally can I ask what you're using this for? I don't really have a way of testing EFI builds here so I'd be reliant on someone else to make sure that this patchset is working as expected.