search

openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
167 stars 136 forks source link

Validator: Warning: Oem.OpenBmc.Certificates not defined in schema OemManager #117

Open gtmills opened 4 years ago

gtmills commented 4 years ago

From the validator: WARNING - Oem.OpenBmc.Certificates not defined in schema OemManager (check version, spelling and casing)

https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/managers.hpp#L1627

  "Oem": {
    "@odata.context": "/redfish/v1/$metadata#OemManager.Oem",
    "@odata.id": "/redfish/v1/Managers/bmc#/Oem",
    "@odata.type": "#OemManager.Oem",
    "OpenBmc": {
      "@odata.context": "/redfish/v1/$metadata#OemManager.OpenBmc",
      "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc",
      "@odata.type": "#OemManager.OpenBmc",
      "Certificates": {
        "@odata.id": "/redfish/v1/Managers/bmc/Truststore/Certificates"
      }

But don't see Certificates defined in the OemManager schema. https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/OemManager_v1.xml https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/JsonSchemas/OemManager/index.json

feistjj commented 4 years ago

cfcd5f6bd introduced this issue, @devenrao can you please fix this issue?

+        oemOpenbmc["Certificates"] = {
+            {"@odata.id", "/redfish/v1/Managers/bmc/Truststore/Certificates"}};
devenrao commented 4 years ago

cfcd5f6 introduced this issue, @devenrao can you please fix this issue?

+        oemOpenbmc["Certificates"] = {
+            {"@odata.id", "/redfish/v1/Managers/bmc/Truststore/Certificates"}};

sure will take a look

edtanous commented 4 years ago

Can this be closed?

gtmills commented 4 years ago

This is still an issue. at Managers/bmc I see

 "Oem": {
    "@odata.context": "/redfish/v1/$metadata#OemManager.Oem",
    "@odata.id": "/redfish/v1/Managers/bmc#/Oem",
    "@odata.type": "#OemManager.Oem",
    "OpenBmc": {
      "@odata.context": "/redfish/v1/$metadata#OemManager.OpenBmc",
      "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc",
      "@odata.type": "#OemManager.OpenBmc",
      "Certificates": {
        "@odata.id": "/redfish/v1/Managers/bmc/Truststore/Certificates"
      }
    }
  },

but nothing in https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/OemManager_v1.xml for certificates. @devenrao Can you have a look?