openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
165 stars 135 forks source link

Network Settings: Static IPv4 Configuration - PATCH doesn't return patch properties #123

Closed dixsie closed 4 years ago

dixsie commented 4 years ago

Expected Behavior

When submitting a PATCH expect PATCH to either return a 200 and the patched properties or a 204.

Actual Behavior

Returns a 200 and only 1 property (host name in this case). Patch response should include IPv4 array.

Response payload:

{
  "HostName": "witherspoon-YL10UF776031"
}
dixsie commented 4 years ago

@ratagupt @gtmills @derick-montague Can you help explain what the response should look like?

edtanous commented 4 years ago

In the intended design, this should be returning 204, and an empty payload.