Add async task for upgrade service

openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC

Apache License 2.0

156 stars 131 forks source link

Add async task for upgrade service #153

Closed vijaykhemka closed 2 years ago

vijaykhemka commented 3 years ago

Currently we are using timeout value for firmware upgrade service and user client wait until firmware upgrade ready or until timeout. We should implement this under asynchronous task because different firmware may take different time to complete upgrade so a timeout value can't be defined and also can't make user to wait for response for longer time.

gtmills commented 3 years ago

I thought we had this..

curl -k -H "Content-Type: application/octet-stream" -X POST -T $image https://${bmc}/redfish/v1/UpdateService
{
  "@odata.id": "/redfish/v1/TaskService/Tasks/2",
  "@odata.type": "#Task.v1_4_3.Task",
  "Id": "2",
  "TaskState": "Running",
  "TaskStatus": "OK"
}

Recent commits like https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39817 and https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39314 added task support for TFTP and added the PercentageComplete..

edtanous commented 2 years ago

Pretty sure this is implemented, and no response from the submitter. Closing.