openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
156 stars 131 forks source link

KVM show disconnected after continue active refresh item on page more than 4 times. #155

Closed StanleyLiu-TW closed 2 years ago

StanleyLiu-TW commented 3 years ago

Enter the KVM page and active "refresh" on page not on browser more than 4 times and KVM status will show "disconnected". It can connect back after "F5" or active "reload page" on browser.

edtanous commented 3 years ago

This is likely a bug in phosphor-webui, not bmcweb. the kvm implementation intentionally limits users to 4 kvm sessions. It's likely the phosphor-webui could be improved to either.

  1. Close the connection properly on a refresh.
  2. Display an error message if too many users are already connected.

If you're interested in putting up a patchset for either of the above, I'm sure they'd be gladly accepted.

edtanous commented 3 years ago

Is this still an issue?

StanleyLiu-TW commented 3 years ago

Sorry for update late, I tried to remove the count from code and work normal.

edtanous commented 2 years ago

Closing as resolved.