search

openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
156 stars 131 forks source link

Redfish: Manager: OEM: Fix warnings around odata.id not matching #166

Closed gtmills closed 6 months ago

gtmills commented 3 years ago 

complex @odata.id: Expected @odata.id to match URI link /redfish/v1/Managers/bmc#/Oem/OpenBmc
complex @odata.id: Expected @odata.id to match URI link /redfish/v1/Managers/bmc#/Oem
edtanous commented 3 years ago

if I'm not mistaken, that looks like the schemas James wrote. I'll add it to my list of things to look at.

The above warnings were redfish service validator?

gtmills commented 3 years ago

The above warnings were redfish service validator?

Yes

edtanous commented 3 years ago

Haven't gotten here yet. It's still on my list.

gtmills commented 6 months ago

I don't see these warning in a recent validator run so they have been fixed. Closing.

I still see this for 

*** /redfish/v1/SessionService
Attempt 1 of /redfish/v1/SessionService
Response Time for GET to /redfish/v1/SessionService: 0.046112860552966595 seconds.
/redfish/v1/SessionService @odata.id: Expected @odata.id to match URI link /redfish/v1/SessionService/
     Type (SessionService.v1_0_2.SessionService), GET SUCCESS (time: 0:00:00.046476)
Attempt 1 of /redfish/v1/SessionService/Sessions
Response Time for GET to /redfish/v1/SessionService/Sessions: 0.005822769366204739 seconds.
     PASS

*** /redfish/v1/SessionService/Sessions
/redfish/v1/SessionService/Sessions @odata.id: Expected @odata.id to match URI link /redfish/v1/SessionService/Sessions/
     Type (SessionCollection.SessionCollection), GET SUCCESS (time: 0:00:00.006165)

All our odata.id don't end in /, except these https://github.com/search?q=repo%3Aopenbmc%2Fbmcweb%20odata.id&type=code https://github.com/openbmc/bmcweb/tree/master/redfish-core/lib#L175 https://github.com/openbmc/bmcweb/tree/master/redfish-core/lib#L285