search

openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
154 stars 131 forks source link

OEM Manager schema needs broken out into appropriate resources #186

Closed edtanous closed 2 weeks ago

edtanous commented 3 years ago

The existing OEM manager schema needs broken out into the appropriate resource schemas for pid controllers fan controllers, and stepwise controllers, with appropraite entity types for each.

When James first built this schema, it was the only non-trivial OEM schema we'd ever built, and it has mistakes, and issues that have haunted us ever since.

Ideally, when this is implemented, we'd leave a compile time option to allow the old behavior for some time, to avoid completely breaking things.

Other issues with the schema:

  1. It declares everything within a collection block, rather than making it an actual resource collection. This makes filtering (when we have it) fail, given how it's organized.
  2. All of the schemas are Complex type, instead of Entity type. This means that the properties within them are maleable. In practice, they're not maleable, and we should have concrete types for each.
edtanous commented 2 weeks ago

This has been resolved with fc1cdd1482eba26a8336f08f4d8af67e47c2adc4