search

openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
154 stars 131 forks source link

Should not look at CoreCount to determine if a Processor is Present or Absent #190

Closed gtmills closed 3 years ago

gtmills commented 3 years ago

Should look at the Present Property on D-Bus like other resources do.

Incorrect (CPU): https://github.com/openbmc/bmcweb/blob/cba4f44896bea631f409cbc9e52d4ddb7d2e86c1/redfish-core/lib/processor.hpp#L208

https://github.com/openbmc/bmcweb/blob/cba4f44896bea631f409cbc9e52d4ddb7d2e86c1/redfish-core/lib/processor.hpp#L65

Correct (GPU): https://github.com/openbmc/bmcweb/blob/cba4f44896bea631f409cbc9e52d4ddb7d2e86c1/redfish-core/lib/processor.hpp#L389

gtmills commented 3 years ago

I think https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/41714 removed all of this