openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
154 stars 131 forks source link

wrapfile-based build doesn't work due to test-case dependency failure. #226

Closed williamspatrick closed 2 years ago

williamspatrick commented 2 years ago

Describe the bug When building bmcweb using meson wrapfiles, the following error is encountered:

In file included from ../redfish-core/ut/configfile_test.cpp:1:
../include/ibm/management_console_rest.hpp:2:10: fatal error: tinyxml2.h: No such file or directory
    2 | #include <tinyxml2.h>
      |          ^~~~~~~~~~~~
compilation terminated.

I attempted to make a minor fix to the meson.build by adding tinyxml to the dependency list for the unit-tests, but this dependency also has a if rest enabled meson_option surrounding it. Is this unit-test suppose to be disabled when the rest meson option is disabled or should this dependency not be controlled by the meson_option?

Environment Plain Linux distribution. Attempting build.

What specific OpenBMC versions (SHA1) did you use? d32c4fa936f9a88fc1dd124201ed11a6a90a18c5

To Reproduce Steps to reproduce the behavior:

  1. clone respository.
  2. meson builddir
  3. cd builddir && ninja

Is this a regression I have no idea.

edtanous commented 2 years ago

What does the IBM management console even use XML for? I don't see any usages in that file, maybe it's just a bad #include? @gtmills any idea who to ask about this one?

gtmills commented 2 years ago

@sunharis @raviteja-b Do you know?

sunharis commented 2 years ago

This include can be removed

williamspatrick commented 2 years ago

remote: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/47787 ibm: remove unused tinyxml2 include [NEW]