search

openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
160 stars 131 forks source link

/redfish/v1/Systems/system/LogServices/PostCodes/Entries/BX-X format different to /redfish/v1/Systems/system/LogServices/EventLog/Entries/XXXX #236

Closed ecnickhuang closed 1 year ago

ecnickhuang commented 2 years ago

[Describtion] Use the DMTF Redfish-Interop-Validator test to test will have "PostCodes entries" fail problem.

[OpenBMC platform]

meta-ibm/conf/machine/witherspoon-tacoma.conf

and can not be tested in QEMU

[bmcweb versions master]

To Reproduce Steps to reproduce the behavior:

  1. Use the DMTF Baseline tool to test and create reports.

git clone https://github.com/DMTF/Redfish-Interop-Validator.git

git clone https://github.com/opencomputeproject/OCP-Profiles.git

Modify IP address in config.ini to OpenBMC correct one and use the command to start the test.

python3 RedfishInteropValidator.py OCP-Profiles/OCPBaselineHardwareManagement.v1_0_1.json --debugging -c config.ini

  1. Check HTML report like the following screenshot

We can find "Failure" in redfish/v1/Systems/system/**LogServices/PostCodes**/Entries/B1-1

image

"FAIL" one entry body image

  1. Expected behavior like :

But in /redfish/v1/Systems/system/LogServices/EventLog/Entries/15 is "PASS"

image

"PASS" one entry body image

The creation of PostCodes/B1-1 is not the same as event log entries/15 and causes the error testing result.

[Has this behavior worked in the past?]
Not tested this item before.

edtanous commented 2 years ago

Please fill out the bug template that should've been presented when you started filling out the bug. It is there to help us correctly triage issues in an efficient manner.

edtanous commented 2 years ago

Based on the screenshots given, it isn't clear how the postcodes as implemented on witherspoon would be able to pass the OCP baseline profile, given that it implemented no message registry, so therefore bmcweb doesn't have the data available to publish message or severity. Created and EntryType could be added. I don't have a witherspoon to even test with, so gerrit reviews to fix the problem are welcome.

edtanous commented 2 years ago

Any more progress here?

jiaqingz-intel commented 1 year ago

I also found this issue, it's because currently /redfish/v1/Systems/system/LogServices/PostCodes/Entries/B1-1 is misformatted and actually returns a LogEntryCollection. I've submmited a patch at https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57773

edtanous commented 1 year ago

Aforementioned patch merged. Closing.