openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
160 stars 131 forks source link

URL arg number assert should contain 5 #270

Closed 1208372113 closed 6 months ago

1208372113 commented 7 months ago

Is this the right place to submit this?

Bug Description

URL arg number assert should contain 5

http/routing.hpp image

Should be static_assert(numArgs <= 5, "Max number of args supported is 5");

Version

https://github.com/openbmc/bmcweb/http/routing.hpp

Additional Information

No response

edtanous commented 7 months ago

Please submit your code to gerrit as a patch.

edtanous commented 6 months ago

have you submitted your change?

gtmills commented 6 months ago

Fixed by https://gerrit.openbmc.org/c/openbmc/bmcweb/+/70126

1208372113 commented 6 months ago

sorry,I don't know how to standardize submission。I haven't used gerrit。

gtmills commented 6 months ago

No worries. https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md for next time.

gtmills commented 6 months ago

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/70126 merged so closing