openbmc / bmcweb

A do everything Redfish, KVM, GUI, and DBus webserver for OpenBMC
Apache License 2.0
157 stars 131 forks source link

Failed to update "BootSourceOverrideTarget": "Cd" #89

Closed SrideviRamesh closed 5 years ago

SrideviRamesh commented 5 years ago
{
  "@Message.ExtendedInfo": [
    {
      "@odata.type": "/redfish/v1/$metadata#Message.v1_0_0.Message",
      "Message": "Successfully Completed Request",
      "MessageArgs": [],
      "MessageId": "Base.1.4.0.Success",
      "Resolution": "None",
      "Severity": "OK"
    }
  ],
  "error": {
    "@Message.ExtendedInfo": [
      {
        "@odata.type": "/redfish/v1/$metadata#Message.v1_0_0.Message",
        "Message": "The request failed due to an internal service error.  The service is still operational.",
        "MessageArgs": [],
        "MessageId": "Base.1.4.0.InternalError",
        "Resolution": "Resubmit the request.  If the problem persists, consider resetting the service.",
        "Severity": "Critical"
      }
    ],
    "code": "Base.1.4.0.InternalError",
    "message": "The request failed due to an internal service error.  The service is still operational."
  }
}bash-4.1$
SrideviRamesh commented 5 years ago

@santoshpuranik please check... failed to update is observed only with parameter 'cd' .

santoshpuranik commented 5 years ago

This is a regression introduced by https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/20776. There was some confusion around what the DBUS property for "ExternalMedia" should be called. What ended up happening is the name was retained as "ExternalMedia" in phosphor-dbus-interfaces, but was changed to "DVD" in bmcweb.

I'll push up a fix to resolve this.

gkeishin commented 5 years ago

Thanks @santoshpuranik routing it to u..

santoshpuranik commented 5 years ago

Fixed here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/21855