search

openbmc / dbus-sensors

D-Bus configurable sensor scanning applications
Apache License 2.0
23 stars 44 forks source link

Use the DISABLE_ options to disable compilation, not just installation #8

Open spinler opened 3 years ago

spinler commented 3 years ago

If the DISABLE_* cmake options were also used to disable compilation, then the bitbake recipe would be able to select dependencies based on which applications are actually enabled, since as of now it has to pull in all dependencies even if an application won't be used.

edtanous commented 3 years ago

Does this actually cause impact to pull in more dependencies? It seems like if we disabled compilation when things were disabled, we'd have to update the dependencies in both cmake/meson and the recipe every time we added a sensor. We already have to do that for the service files, but also having to declare per-sensor dependencies in two places seems like a step backward, but if there's a good use case for this, I'm not necessarily against it.