openbmc / docs

OpenBMC Documentation
Creative Commons Attribution 4.0 International
277 stars 307 forks source link

dbus-interfaces: Add org.openbmc.control.BmcFlash.update method #26

Closed causten closed 8 years ago

causten commented 8 years ago

I created the pull request for skeleton, now I am making sure the documentation reflects the change too. Basically it allows someone to copy a bmc image on to the server to flash it. This removes the requirement for a tftp server to be used

https://github.com/openbmc/skeleton/pull/87


This change is Reviewable

jk-ozlabs commented 8 years ago

Hi Chris, thanks for the update - the patch itself looks good to me. Can you add a little info, and a signed-off-by line to the changelog though?

Even just changing the title to

dbus-interfaces: Add org.openbmc.control.BmcFlash.update method

would be great.

jk-ozlabs commented 8 years ago

(otherwise we end up with lots of commits just saying "update x")

williamspatrick commented 8 years ago

@causten - @jk-ozlabs is expecting an update with a better commit message.

causten commented 8 years ago

done

jk-ozlabs commented 8 years ago

I still see the same commit there.

jk-ozlabs commented 8 years ago

Thanks for the updated commit, but there's still no Signed-off-by, and the commit title is still the same.

I'm very happy to help out by manually updating the commit title, but I won't forge your Signed-off-by.

williamspatrick commented 8 years ago

Part of the problem is that it appears @causten is editing directly in Github for this. The committer is 'causten@users.noreply.github.com', which is what Github shows if you have your settings set to hide your user. Since he is editing directly on Github, I don't think the Signed-Off-By is even an option.

@causten - You'll need to amend this commit locally in a git repository. 'git commit --amend --reset-author --signoff' should be what you need.

jk-ozlabs commented 8 years ago

Woot!

jk-ozlabs commented 8 years ago

OK, merged and pushed. Thanks for the contribution.