search

openbmc / docs

OpenBMC Documentation
Creative Commons Attribution 4.0 International
267 stars 305 forks source link

Document accessible markup patterns for icon use #45

Closed derick-montague closed 4 years ago

gtmills commented 5 years ago

@derick-montague Can you add a description? Should this go in the webui repo instead?

derick-montague commented 5 years ago

@gtmills I will update the description. I was making this to address some of our conversation in the mail list. Should this type of documentation be done in the webui repo or is it actual documentation?

@edtanous:

My take on this is that we should do whatever is easiest to maintain. Today we use both custom SVGs inline in the nav bar, as well as some font icons from the glyficons pack. There were some concerns about accessibility on font icons that we should open a bug up on github and understand. I would really like if that bug led to some documentation about how we handle accessibility, and what we would like to see from patchsets going forward in clear and concise rules, and a patchset to make the UI as it stands consistent in this regard.

williamspatrick commented 4 years ago

Can this be closed or moved? @derick-montague

derick-montague commented 4 years ago

Can this be closed or moved? @derick-montague

We can close this from my perspective. Thanks @williamspatrick.