openbmc / docs

OpenBMC Documentation
Creative Commons Attribution 4.0 International
279 stars 307 forks source link

[architecture/code-update/emmc-storage-design.md] Fixes #88

Closed Olf0 closed 1 week ago

Olf0 commented 2 weeks ago

Because it is proper documentation which is also should be easily consumable by everyone, e.g. also non-native speakers.

williamspatrick commented 2 weeks ago

Thank you for the suggestions. Please submit via Gerrit. We don't take GitHub PRs.

Olf0 commented 2 weeks ago

I do not use Gerrit (never did and are not planning to, especially not for a "drive-by contribution" due to simply having stumbled over these issues while reading the text), hence take it or leave it.

I.e., you sure may commit these changes via any other route, as long you properly attribute me as the original author. It is Git, hence there are many tools with which the changes from https://github.com/Olf0/docs/tree/patch-1 can be merged into https://github.com/openbmc/docs/tree/master.

williamspatrick commented 1 week ago

For better or worse, we are required to ensure all developers contributing to this project are covered by a signed CLA, even for "drive-by contributions". This is documented in the CONTRIBUTING.md file here. We track this membership through Gerrit permission groups. If you're not covered by a CLA, we can't take this contribution through any method.

Olf0 commented 1 week ago

Well, please mind then, that I (as the original author) hold the copyright of these changes: It would be personally (i.e. socially) and legally problematic to see these changes (or sub- / supersets of them) being committed to OpenBMC at any time in the future without clearly attributing them to me as their original author.

My intention was to make these improvements available to everyone under the extant licence, but if that is not wanted, I unfortunately have to accept that.