openbmc / openbmc-build-scripts

Apache License 2.0
19 stars 50 forks source link

Meson dependencies check won't pick list items #27

Closed FighterNan closed 4 years ago

FighterNan commented 4 years ago

https://github.com/openbmc/openbmc-build-scripts/blob/d2176ef9704d968858f031e89ace9d1b876d3bf5/scripts/unit-test.py#L758

The patten fails to match dependencies declared in a list, for example,

some_deps = [
  dependency('lib1'),
  dependency('lib2'),
]

r"dependency\('([^']*)'.*?\),?\n" should fix the problem.

FighterNan commented 4 years ago

Please refer to this commit.