openbmc / openbmc-build-scripts

Apache License 2.0
19 stars 50 forks source link

fix: disable Dockerfile always check for package updates #7

Closed csmart closed 8 years ago

csmart commented 8 years ago

set a static datestamp so that apt-get/dnf aren't run each time a new docker container is built. Increment it if you want to refresh the package databases in order to install new software or if something is out of date.

@shenki


This change is Review on Reviewable

shenki commented 8 years ago

Why have the datestamps at all? I think we should remove them._

Also, should be doing the apt-get update && apt-get install as the one run command. See https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/

csmart commented 8 years ago

@shenki yep, pushed new commit.

shenki commented 8 years ago

Looking good! A few more comments.