Open Kostr opened 3 years ago
There is reason why it was added, recent last year i believe the -U
so it give a first try with -U , and if the driver on the system accepts it , it takes the -U on all test suites executing IPMI.. if not without it.. so its more of a pre-check to support old and new method of doing it..
it may look un-necessary but it's always good to have the support till we finally do away with it..
@gkeishin Thanks for the explanation! Maybe some of this information should be added to the test output? Something like Check for -U option support in BMC IPMI subsystem
. Because in the other way it is confusing why the test system is making calls that it weren't asked for.
Also as I understand your commit is only about ipmitool power status
call. Can you say something about Redfish calls? Redfish is a completely different subsystem. bmcweb
app can not be even present on the BMC, but it shouldn't affect IPMI tests.
Maybe some of this information should be added to the test output? Something like Check for -U option support in BMC IPMI subsystem
Can you say something about Redfish calls? Redfish is a completely different subsystem. bmcweb app can not be even present on the BMC, but it shouldn't affect IPMI tests.
where the code decides if its ONLY REST (xyz) or ONLY Redfish(/redfish/v1/) or both REST and Redfish. To support and navigate / load which path test suite needs to take, those pre-check are being made.
we would want the code to ideally detect and do its stuff, however having said that.. may be down, we would want to cleanly handle them but for now the transition is mixed RESTful. ( REST Legacy(xyz) and Redfish support) and stay that way.
Thanks Kostr and gkeishin for taking up this issue
When I was helping Vijay Khemka to write a Test Case "ipmi: add test for FRU device name" (https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-test-automation/+/41817), I've noticed that besides an actual
ipmitrool fru
command the test framework executes series of other commands:There is no explicit
Suite Setup
in a robot file, so I'm wondering, should all of these starting commands be executed at all? For example is it appropriate that IPMI FRU test depends on a presence of a Redfish interface?are coming from the inclusion of
Resource bmc_redfish_resource.robot
in alib/openbmc_ffdc_methods.robot
file. I was able to get rid of them with the comment of this include string, or with the help of-v MTLS_ENABLED:True
option.are coming from a file https://github.com/openbmc/openbmc-test-automation/blob/master/lib/ipmi_client.py , particularly from this part of file:
Is it really necessary to call this? FRU test seems to be working without it.