search

openbmc / openbmc-test-automation

Apache License 2.0
100 stars 92 forks source link

many test keywords and tags do not match #2149

Closed generatz closed 2 years ago

generatz commented 2 years ago

There are a number of cases where test keywords and associated tags do not correspond as intended. For example the tag for the test shown below is missing an 's' on the end of 'Addresse':

Configure And Verify Multiple IPv4 Addresses
    [Documentation]  Configure multiple IPv4 addresses and verify.
    [Tags]  Configure_And_Verify_Multiple_IPv4_Addresse

This is a cause for confusion and error when using the tests.

Does there exist or is there already a trivial way to screen for these so they can easily be remediated (and perhaps be caught early, say with Jenkins testing)?

gkeishin commented 2 years ago

Good catch.. mismatching tag with test cases shouldn't be a problem but a practice where we keep the same.

Having said that, codespell we run offline but that also doesn't seem to catch for tags ones. We will keep eye for newer code and older existing one we fix as we go when reported

gkeishin commented 2 years ago

@generatz Fixed I think this should cover for all https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-test-automation/+/50355