search

openbmc / openbmc-test-automation

Apache License 2.0
100 stars 92 forks source link

Suite Setup in Redfish.Systems.Eventlog.Test Event Service does not apply to all test cases #2162

Closed generatz closed 2 years ago

generatz commented 2 years ago

The suite setup in redfish/systems/eventlog/test_event_service.robot requires that the variables ${REMOTE_SERVER_IP} and ${HTTPS_PORT} not be empty. But ${REMOTE_SERVER_IP} has no default value. Consequently, until it is defined, both test cases in the suite fail. However, one of the two cases, Verify Event Service Available, does not require these two variables.

The suite setup requirement should be converted into a test requirement for the other test - the only test that requires the two variables.

gkeishin commented 2 years ago 
Suite Setup Execution
    [Documentation]  Do the suite setup.

    Should Not be Empty  ${REMOTE_SERVER_IP}
    Should Not be Empty  ${HTTPS_PORT}

HTTPS_PORT by default we know 443 , however the remote server IP where the event is configured to sent is dependent on user setup and not something, we should default.

That's why the above is check is done at the suite set up.

Having said that, at least we can add the Documentation to tell user how to set it up.

gkeishin commented 2 years ago

I talked to @adathatri about the aim of this test, so looks like it doesn't need any valid IP to do validation. The scope of this suite is to be able to add another web server IP and it should get added to the subscription.

@adathatri can u just assign a random IP and clear up the subscription once done ?

gkeishin commented 2 years ago

Commit up https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-test-automation/+/51304

This should do for now, till we add newer test cases to do real event notification testing using the remote web server capable to listen to the traffic events coming to it