openbmc / openbmc-test-automation

Apache License 2.0
100 stars 92 forks source link

corrections to redfish paths needed in redfish/systems/test_systems_inventory.robot #2165

Closed generatz closed 2 years ago

generatz commented 2 years ago

The paths used by the following tests in the redfish/systems/test_systems_inventory.robot suite require modifications: Get Motherboard Serial And Verify Populated Verify Motherboard Manufacturer Field Value Populated Verify Motherboard Partnumber Field Value Populated

The field after /redfish/v1/Chassis/ should probably be determined dynamically using OData or using ${CHASSIS_ID}

As a workaround, I used ${CHASSIS_ID} as show with this git diff:

diff --git a/redfish/systems/test_systems_inventory.robot b/redfish/systems/test_systems_inventory.robot                                                                                                       
index 915448c1..8bef2f10 100755                                                                                                                                                                                
--- a/redfish/systems/test_systems_inventory.robot                                                                                                                                                             
+++ b/redfish/systems/test_systems_inventory.robot                                                                                                                                                             
@@ -122,7 +122,7 @@ Get Motherboard Serial And Verify Populated                                                                                                                                                
     [Tags]  Get_Motherboard_Serial_And_Verify_Populated                                                                                                                                                       

     ${serial_number}=  Redfish.Get Attribute                                                                                                                                                                  
-    ...  ${REDFISH_CHASSIS_URI}motherboard  SerialNumber                                                                                                                                                      
+    ...  ${REDFISH_CHASSIS_URI}${CHASSIS_ID}  SerialNumber                                                                                                                                                    
     Valid Value  serial_number                                                                                                                                                                                
     Rprint Vars  serial_number                                                                                                                                                                                

@@ -132,7 +132,7 @@ Verify Motherboard Manufacturer Field Value Populated                                                                                                                                      
     [Tags]  Verify_Motherboard_Manufacturer_Field_Value_Populated                                                                                                                                             

     ${motherboard_manufacturer}=  Redfish.Get Attribute                                                                                                                                                       
-    ...  ${REDFISH_CHASSIS_URI}motherboard  Manufacturer                                                                                                                                                      
+    ...  ${REDFISH_CHASSIS_URI}${CHASSIS_ID}  Manufacturer                                                                                                                                                    
     Valid Value  motherboard_manufacturer                                                                                                                                                                     

@@ -141,7 +141,7 @@ Verify Motherboard Partnumber Field Value Populated                                                                                                                                        
     [Tags]  Verify_Motherboard_Partnumber_Field_Value_Populated                                                                                                                                               

     ${motherboard_part_number}=  Redfish.Get Attribute                                                                                                                                                        
-    ...  ${REDFISH_CHASSIS_URI}motherboard  PartNumber                                                                                                                                                        
+    ...  ${REDFISH_CHASSIS_URI}${CHASSIS_ID}  PartNumber
     Valid Value  motherboard_part_number
gkeishin commented 2 years ago

Fix in review https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-test-automation/+/51482