search

openbmc / openbmc-test-automation

Apache License 2.0
100 stars 92 forks source link

update service: need support uploading same image for multiple times #2167

Closed minimada closed 10 months ago

minimada commented 2 years ago

The openbmc merged the new software manager commit: https://github.com/openbmc/phosphor-bmc-code-mgmt/commit/59b640b07148c56e0a344dda198fcac0cd9af836

This function will affect the version ID presentation. For example, the exist version will calculate by version + flashId But when user upload image, the version id will calculate by version + salt

And the utility function "Redfish Upload Image And Check Progress State" in lib/redfish_code_update_utils.robot use the fixed version id to check image update status.

I think the update service test cases may need add some modification for support software manager code changed.

gkeishin commented 2 years ago

@susilsi7 can u check on this ?

gkeishin commented 2 years ago

@susilsi7 any new update on this one ?

susilsi7 commented 2 years ago

Can you point me a test case for this scenario.

For Image id, we are using till image becomes active and we should be good there.

minimada commented 2 years ago

For example: Update Service.Test Redfish Bmc Code Update.Redfish Code Update With ApplyTime Immediate.

gkeishin commented 10 months ago

now the firmware allows same image to upload multiple times. @susilsi7 can you check if this is done ?

susilsi7 commented 10 months ago

Same firmware upload multiple times, code is available with keyword "Redfish Code Update Same Firmware Multiple Times" and file path is "openbmc-test-automation/redfish/update_service/test_redfish_bmc_code_update.robot".

gkeishin commented 10 months ago

Thank you @susilsi7 @minimada

Closing the ticket.