test Teardown in redfish/update_service/test_redfish_image_upload.robot does not complete (no FFDC)

[generatz]

Due to FW problems these tests failed for me but the test Teardown did not complete, instead it generated an error. I suspect but don't know if there is a requirement that test [Teardown] must be in the test case, but I was able to remediate the problem by moving the test teardown from Redfish Bad Firmware Update to each individual test case. (I also added some Valid Value checks, that are generally helpful.) Here is the patch:

diff --git a/redfish/update_service/test_redfish_image_upload.robot b/redfish/update_service/test_redfish_image_upload.robot
index 105a0a08..07d2707d 100644
--- a/redfish/update_service/test_redfish_image_upload.robot
+++ b/redfish/update_service/test_redfish_image_upload.robot
@@ -41,6 +41,7 @@ ${image_id}            ${EMPTY}
 Redfish Failure To Upload BMC Image With Bad Manifest
     [Documentation]  Upload a BMC firmware with a bad MANFIEST file.
     [Tags]  Redfish_Failure_To_Upload_BMC_Image_With_Bad_Manifest
+    [Teardown]  Test Teardown Execution
     [Template]  Redfish Bad Firmware Update

     # Image File Name
@@ -50,6 +51,7 @@ Redfish Failure To Upload BMC Image With Bad Manifest
 Redfish Failure To Upload Empty BMC Image
     [Documentation]  Upload a BMC firmware with no kernel image.
     [Tags]  Redfish_Failure_To_Upload_Empty_BMC_Image
+    [Teardown]  Test Teardown Execution
     [Template]  Redfish Bad Firmware Update

     # Image File Name
@@ -59,6 +61,7 @@ Redfish Failure To Upload Empty BMC Image
 Redfish Failure To Upload Host Image With Bad Manifest
     [Documentation]  Upload a PNOR firmware with a bad MANIFEST file.
     [Tags]  Redfish_Failure_To_Upload_Host_Image_With_Bad_Manifest
+    [Teardown]  Test Teardown Execution
     [Template]  Redfish Bad Firmware Update

     # Image File Name
@@ -68,6 +71,7 @@ Redfish Failure To Upload Host Image With Bad Manifest
 Redfish Failure To Upload Empty Host Image
     [Documentation]  Upload a PNOR firmware with no kernel Image.
     [Tags]  Redfish_Failure_To_Upload_Empty_Host_Image
+    [Teardown]  Test Teardown Execution
     [Template]  Redfish Bad Firmware Update

     # Image File Name
@@ -115,6 +119,11 @@ Redfish TFTP Failure To Upload Empty Host Image
 Suite Setup Execution
     [Documentation]  Do the suite setup.

+    Valid Value  OPENBMC_HOST
+    Valid Value  OPENBMC_USERNAME
+    Valid Value  OPENBMC_PASSWORD
+    Valid Value  BAD_IMAGES_DIR_PATH
+    Valid Value  TFTP_SERVER
     Redfish.Login
     Redfish Delete All BMC Dumps
     Redfish Purge Event Log
@@ -123,7 +132,6 @@ Suite Setup Execution
 Redfish Bad Firmware Update
     [Documentation]  Redfish firmware update.
     [Arguments]  ${image_file_name}
-    [Teardown]  Test Teardown Execution

     # Description of argument(s):
     # image_file_name  The file name of the image.

[gkeishin]

@susilsi7 Please look into it

[gkeishin]

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-test-automation/+/52550