search

openbmc / openbmc-test-automation

Apache License 2.0
100 stars 92 forks source link

Factory_reset_sub_menu and test_host_console_sub_menu.robot #2238

Open justin0309 opened 7 months ago

justin0309 commented 7 months ago

@gkeishin Are these two modifications due to the need to move the code content later? Or are there other purposes? Or is it that we can modify the position where he wants to appear at will? Because these two tests correspond to each other, the code of webui-vue is still original. According to the old test, it can pass, but after changes, it fails.

https://github.com/openbmc/openbmc-test-automation/commit/0c1a34889c93ba0ed7127e802f5e39b298e74031

https://github.com/openbmc/openbmc-test-automation/commit/701789509e5ed020137a355daaed00cc574a531c

gkeishin commented 7 months ago

It was failing in our environment so we fixed it up. Having said that, we didn't get any feedback on GUI earlier, so we merged it.

Good that you are providing feedback that gives us now the view on how to drive Web UI related changes testing better.

@justin0309 let us know if you want us to revert the changes.

FYI @rramyasr @rahulmah