geissonator commented 7 years ago

The host requires the ability to control https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/Boot/RebootPolicy.interface.yaml

AutoReboot

The team is working on defining a sensor for this, once done we just need to update host ipmid to associated the new sensor with this setting.

bjwyman commented 7 years ago

STATUS

10/04

Today: Informed by Spinler that I am the lucky new owner of this. Started looking things over, assuming this has something to do with openbmc/phosphor-host-ipmid repo. Not sure how I will know when the new sensor for this is defined.
Next: Figure out how to tell when the sensor is defined, and what all is entailed with updating host ipmid to associate the new sensor with the setting.
Blockers: ???

10/05

Today: Got the values for the sensor. Looked at gerrit commits for similar update for TPMEnable. Updated the YAML file with what I hope is correct, but at a bit of a loss on how to see these sensors, how to change them, how to test any changes I make. I am assuming ipmitool on the host side would somehow be involved.
Tomorrow: Try to figure out how to interact with these sensors, how to go about testing/verifying I have something working without breaking something else. Get the openbmc/phosphor-host-ipmid files updated.
Blockers: Questions on verifying/testing?

10/06

Today: Not much to note for progress on this one. I spent quite a bit of time on review. However, while doing review, noted another file with reference to auto_reboot, and wondering if I have a typo in one of the updates I was doing.
Next: Make progress on how to verify I did not break something, get phosphor-host-ipmid files updated. I also just noticed that I thought I had a task list, and yet I do not see one.
Blockers: Questions on verify/test.

10/10

Today: Most of time on defect code and test, some review, then a little time looking at the history of similar changes for IPMI.
Tomorrow: Get in code updates to handle new entity ID and sensor type.
Blockers: None.

10/12

Today: Mentioned some lack of knowledge on IPMI during scrum, later talked to Spinler to figure out some of this entity ID, sensor type, command, ... information. Figured out what I think are the necessary updates to generate code to support this. Pushed up witherspoon.conf and config.yaml changes, but not sure on testing.
Tomorrow: Figure out how to test this. There must be a host side to try something.
Blockers: Testing.

10/13

Today: No progress on this. Spent most of the day on CQ defect bridged to issue 2473.
Next: Get back to figuring out how to test my changes.
Blockers: Testing.

10/16

Today: Tracked down HostBoot developer working on the code from that side. Will work on patch testing plan when ready. Seems like ipmitool from host side may work as well, but not certain of command and flags.
Tomorrow: Patch test with HostBoot?
Blockers: Testing.

10/17

Today: Struggle to get time on system that boots to host OS. No word on PNOR patch for HostBoot side. Pushed up code, did not assign reviewers.
Tomorrow: Tray again for system time and PNOR patch.
Blockers: Testing.

10/24

Today: MRW revision bump commit merged, but needed to rebase the YAML update commit.
Tomorrow: Review feedback?
Blockers: +2 review and merge.

10/25

Today: Hardware test failing. Pushed up another rebase to attempt to get test passing.
Tomorrow: Test good? Review feedback?
Blockers: HW CI, +2 review and merge.

bjwyman commented 7 years ago

Entity ID: 0x21 Sensor Type: 0x09

Looks like one can confirm the definition via this commit: https://github.com/open-power/witherspoon-xml/commit/24d2f6d98568f0b23d1eb3bb9f876a638be4ae37

bjwyman commented 7 years ago

Without my changes:

[v2cib530@gfwr703 ~]$ ipmitool -I lanplus -H $BMC -P 0penBmc raw 0x04 0x2D 0xda
Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x0 cmd=0x2d rsp=0xcb): Requested sensor, data, or record not found
[v2cib530@gfwr703 ~]$

With my changes:

root@witherspoon:~# busctl tree xyz.openbmc_project.Settings --no-pager
└─/xyz
  └─/xyz/openbmc_project
    ├─/xyz/openbmc_project/control
    │ ├─/xyz/openbmc_project/control/host0
    │ │ ├─/xyz/openbmc_project/control/host0/TPMEnable
    │ │ ├─/xyz/openbmc_project/control/host0/auto_reboot
    │ │ ├─/xyz/openbmc_project/control/host0/boot
    │ │ │ └─/xyz/openbmc_project/control/host0/boot/one_time
    │ │ ├─/xyz/openbmc_project/control/host0/power_cap
    │ │ ├─/xyz/openbmc_project/control/host0/power_restore_policy
    │ │ └─/xyz/openbmc_project/control/host0/restriction_mode
    │ └─/xyz/openbmc_project/control/minimum_ship_level_required
    ├─/xyz/openbmc_project/network
    │ └─/xyz/openbmc_project/network/host0
    │   └─/xyz/openbmc_project/network/host0/intf
    │     └─/xyz/openbmc_project/network/host0/intf/addr
    └─/xyz/openbmc_project/time
      ├─/xyz/openbmc_project/time/owner
      └─/xyz/openbmc_project/time/sync_method
root@witherspoon:~# busctl introspect xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/auto_reboot  --no-pager
NAME                                          TYPE      SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable           interface -         -            -
.Introspect                                   method    -         s            -
org.freedesktop.DBus.Peer                     interface -         -            -
.GetMachineId                                 method    -         s            -
.Ping                                         method    -         -            -
org.freedesktop.DBus.Properties               interface -         -            -
.Get                                          method    ss        v            -
.GetAll                                       method    s         a{sv}        -
.Set                                          method    ssv       -            -
.PropertiesChanged                            signal    sa{sv}as  -            -
xyz.openbmc_project.Control.Boot.RebootPolicy interface -         -            -
.AutoReboot                                   property  b         true         emits-change writable
root@witherspoon:~#
root@witherspoon:~# busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/auto_reboot xyz.openbmc_project.Control.Boot.RebootPolicy AutoReboot
b true
root@witherspoon:~#

[v2cib530@gfwr703 ~]$ ipmitool -I lanplus -H $BMC -P 0penBmc raw 0x04 0x2d 0xda
 00 00 02 00
[v2cib530@gfwr703 ~]$

root@witherspoon:~# busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/auto_reboot xyz.openbmc_project.Control.Boot.RebootPolicy AutoReboot b false
root@witherspoon:~# busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/auto_reboot xyz.openbmc_project.Control.Boot.RebootPolicy AutoReboot
b false
root@witherspoon:~#

[v2cib530@gfwr703 ~]$ ipmitool -I lanplus -H $BMC -P 0penBmc raw 0x04 0x2d 0xda
 00 00 01 00
[v2cib530@gfwr703 ~]$

bjwyman commented 7 years ago

Did some testing with @mderkse1 with a HostBoot patch. Somehow a flag gets set, and if that is set, certain code paths will disable AutoReboot in order to stop on errors. The AutoReboot was set to true, but then after a poweron, it was set to false, so apparently the path from HostBoot to the BMC is working to change the AutoReboot value.

rfrandse commented 7 years ago

https://gerrit.openbmc-project.xyz/7301 AutoReboot: Add support for AutoReboot sensor type Resolves: #2398 Allow in band IPMI to enable/disable automatic reboots

openbmc / openbmc

Allow in band IPMI to enable/disable automatic reboots #2398

STATUS