search

openbmc / phosphor-dbus-interfaces

YAML descriptors of standard dbus interfaces
Apache License 2.0
39 stars 65 forks source link

Spdm related schema added to phosphor-dbus-interfaces #19

Closed sunzc closed 1 year ago

sunzc commented 1 year ago

The D-Bus Interface for ComponentIntegrity and TrustedComponent is based on DSP2046_2022.3.pdf. These two interfaces are needed to implement the SPDM D-Bus agent.

Add Inventory/Item/Rot.interface to represent root of trust. This is optional. It makes enumerating SPDM-capable devices or other Root-of-trust devices easier.

Note, yaml files define the interfaces. meson files are automatically generated from the yaml files and are used for building the dbus phosphor interface library.

williamspatrick commented 1 year ago

Please submit via Gerrit. We do not take PRs on any OpenBMC repo.

sunzc commented 1 year ago

Hi William, I followed the instructions here(https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#submitting-changes-via-gerrit-server-to-openbmc) to setup gerrit. When I try to push to gerrit for review (git push gerrit). I got the following error

$ git push gerrit
Enumerating objects: 65, done.
Counting objects: 100% (65/65), done.
Delta compression using up to 16 threads
Compressing objects: 100% (46/46), done.
Writing objects: 100% (53/53), 9.61 KiB | 984.00 KiB/s, done.
Total 53 (delta 25), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (25/25)
remote: error: branch refs/heads/master:
remote: Push to refs/for/master to create a review, or get 'Push' rights to update the branch.
remote: User: sunzc
remote: Contact an administrator to fix the permissions
remote: Processing changes: refs: 1, done    
To ssh://openbmc.gerrit/openbmc/phosphor-dbus-interfaces
 ! [remote rejected] HEAD -> master (prohibited by Gerrit: not permitted: update)
error: failed to push some refs to 'ssh://openbmc.gerrit/openbmc/phosphor-dbus-interfaces'

It asks me to Contact an administrator to fix the permissions, do you know how to apply for a push permission? Thanks!

My git remote:

$ git remote -v
gerrit  ssh://openbmc.gerrit/openbmc/phosphor-dbus-interfaces (fetch)
gerrit  ssh://openbmc.gerrit/openbmc/phosphor-dbus-interfaces (push)

My gerrit push config

git config remote.gerrit.push HEAD:refs/heads/master
williamspatrick commented 1 year ago

remote: Push to refs/for/master to create a review, or get 'Push' rights to update the branch.

williamspatrick commented 1 year ago

Gerrit has a magic “refs/for/master” that you need to push to in order to create a code review. The push you were attempting was to push into the branch, bypassing review, which almost no one is allowed to do.