search

openbmc / phosphor-dbus-interfaces

YAML descriptors of standard dbus interfaces
Apache License 2.0
39 stars 65 forks source link

Incorrect enum associations in Dimm interface #8

Open kellycouch opened 4 years ago

kellycouch commented 4 years ago

\openbmc\phosphor-dbus-interfaces\xyz\openbmc_project\Inventory\Item\Dimm.interface.yaml

Contains two enums: Type and DeviceType.

Currently, enum DeviceType is associated with property MemoryType and enum Type is not associated with any property.

Both are incorrect. See SMBIOS specification which these are intended to align with.

Current:

- name: MemoryType
  type: enum[self.DeviceType]
  description: >
      Type of memory.
- name: MemoryTypeDetail
  type: string
  description: >
      Additional detail on Memory, such as Synchronous, Static column, etc.

Proposed:

- name: MemoryType
  type: enum[self.Type]
  description: >
      Type of memory.
- name: MemoryTypeDetail
  type: enum[self.DeviceType]
  description: >
      Additional detail on Memory, such as Synchronous, Static column, etc.
bradbishop commented 4 years ago

Hi @cyang29 do you care to comment on this?