search

openbmc / phosphor-host-ipmid

dbus-based ipmid for host-endpoint IPMI commands
Apache License 2.0
36 stars 73 forks source link

The Test Password with the wrong length is throwing the error code 0xc7 instead of 0x81 #204

Open Mani-v opened 4 months ago

Mani-v commented 4 months ago

As pre-Intel specification document session 22.30 Set User Password command pointing to Table 22-35 mandatory response Data expected is 81h for password test failed with wrong password size.

Response needs to be pointing to _ipmiCCPasswdFailWrongSize = 0x81_ error code, but with the current code base its responding as 0xc7

Is there a particular rationale for departing from the IPMI specification and opting for generic error codes instead, specifically for cases like "Request data length invalid (C7h)" as outlined in Table 5-2: Completion Codes?

williamspatrick commented 4 months ago

Can you submit a fix in Gerrit? It's probably just an oversight or mistake in the implementation.

lxwinspur commented 1 month ago

Can you submit a fix in Gerrit? It's probably just an oversight or mistake in the implementation.

@Mani-v fixed: https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/73068 Could you please review this patch?