set-property Does not Persist

openbmc / phosphor-inventory-manager

Apache License 2.0

8 stars 9 forks source link

set-property Does not Persist #6

Open santoshpuranik opened 2 years ago

santoshpuranik commented 2 years ago

PIM does not persist properties set via the org.freedesktop.DBus.Properties Set method. One has to use Notify to get the property to persist. This is counterintuitive since org.freedesktop.DBus.Properties Set is the standard way to set D-Bus properties.

Since the code uses sdbusplus bindings to supply the implementation for property set, it is not trivial to get it to persist.

williamspatrick commented 2 years ago

Should the properties be read/write to begin with? I thought we expected inventory items to come in through Notify.

geissonator commented 2 years ago

We have situations where the host firmware is setting certain properties over PLDM, which just wants to call a generic "set-property" call. Some of these go to PIM backed objects, some go elsewhere. If PIM doesn't support set-property then code will need special checks to determine whether to call Notify vs. set-property.