search

openbmc / phosphor-net-ipmid

Network IPMI server
Apache License 2.0
9 stars 11 forks source link

IPMI Firmware Revision mismatch #3

Open gkeishin opened 5 years ago

gkeishin commented 5 years ago

Expecting Firmware Revision : 0.00 to be populated with 2.7 

$ ipmitool -I lanplus -H xx.xx.xx.xx -U root -P 0penBmc mc info
Device ID                 : 0
Device Revision           : 0
Firmware Revision         : 0.00
IPMI Version              : 2.0
Manufacturer ID           : 42817
Manufacturer Name         : Unknown (0xA741)
Product ID                : 16975 (0x424f)
Product Name              : Unknown (0x424F)
Device Available          : yes
Provides Device SDRs      : yes
Additional Device Support :
    Sensor Device
    SEL Device
    FRU Inventory Device
    Chassis Device
Aux Firmware Rev Info     :
    0x01
    0x62
    0x00
    0x00

root@witherspoon:~# cat /etc/os-release
ID="openbmc-phosphor"
NAME="Phosphor OpenBMC (Phosphor OpenBMC Project Reference Distro)"
VERSION="2.7.0-dev"
VERSION_ID="2.7.0-dev-162-g052de7c"
PRETTY_NAME="Phosphor OpenBMC (Phosphor OpenBMC Project Reference Distro) 2.7.0-dev"
BUILD_ID="2.7.0-dev"
OPENBMC_TARGET_MACHINE="witherspoon"
root@witherspoon:~#
gkeishin commented 5 years ago

@tomjoseph83 @vmauery @nasamuffin anyone here ?

AlexanderAmelkin commented 5 years ago

I believe this is due to "bad" VERSION_ID. The parser in phosphor-host-ipmid doesn't know anything about M.m.s-WWW-NNN-gXXXXXX format. There are just two version formats it claims to understand:

  1. v0.6-19-gf363f61-dirty
  2. v1.99.10-113-g65edf7d-r3-0-g9e4f715

I previously made a patch to the parser to accept YADRO version format and to also put git hash into AUX revision if none is provided in dev_id.json. If anyone is interested, I can post it here or in Gerrit.

AlexanderAmelkin commented 5 years ago

Also, it's unwise IMO to use three-part versioning scheme (2.7.0) provided that IPMI only has space for two parts (2.7).

Anyway, for releases tagged like 2.7.0 without the -dev, everything should work fine even now.

gkeishin commented 5 years ago

Routing it to @tomjoseph83 there.. Thanks