search

openbmc / phosphor-networkd

Apache License 2.0
18 stars 49 forks source link

DNS server that is configured via DHCP, is not shown in redfish command #29

Closed prkatti1 closed 3 years ago

prkatti1 commented 5 years ago

DNS server that is configured via DHCP, is not shown in redfish command. Both nameserver and staticnameserver fields are empty. This gives the impression that no DNS server is configured on BMC although DNS servers are configured which is visible in /etc/resolv.conf

manojkiraneda commented 5 years ago

Resolved by : https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-networkd/+/24224/ https://gerrit.openbmc-project.xyz/#/c/openbmc/bmcweb/+/24229/ https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/24274/

ratagupt commented 5 years ago

Currently, in ethernet interface D-bus interface there is nameserver property which keeps the static DNS entries and there is no mechanism to show the dynamic DNS entries.

Me and William had a discussion on the same, needs to change the Ethernet D-bus interface.

Proposal is to have two properties instead of one. 1) Nameservers: This will keep the DHCP as well as the Static DNS entries(ReadOnly) 2) StaticNameservers: This will keep only the Static DNS entries(Read/Write).

This is aligned with Redfish data modeling. @wak-google ^^^^

Impacted components: bmcweb,phosphor-networkd,phosphor-dbus-interfaces,openbmctool,openbmc-test-automation.

manojkiraneda commented 5 years ago

As per the new proposal mentioned : https://lists.ozlabs.org/pipermail/openbmc/2019-September/018399.html

I have made the changes and the Code is Up for Review : https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/26060/ https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-networkd/+/26115/ https://gerrit.openbmc-project.xyz/#/c/openbmc/bmcweb/+/25804/

manojkiraneda commented 4 years ago

The code is merged in master.

manojkiraneda commented 4 years ago

@prkatti1 can we close this issue ? as it is already merged.

ratagupt commented 3 years ago

Let's close this one