openbmc / phosphor-networkd

Apache License 2.0
18 stars 49 forks source link

BMC does not throw error on configuring some invalid MAC address #52

Closed swe12345 closed 1 year ago

swe12345 commented 2 years ago

Pre condition:

MAC address length is 6 bytes each byte is hex value and is seperated by Colon ':' Example: AA:AA:AA:AA:AA:AA

Steps to recreate the issue:

Configure 7 bytes MAC address value= AA:AA:AA:AA:AA:B

using the curl command: curl -k -H "X-Auth-Token:$bmc_token" PATCH -d '{'MACAddress': 'AA:AA:AA:AA:AA:AA:B'}' https://$bmc/redfish/v1/Managers/bmc/EthernetInterfaces/eth0

Actual Result: AA:AA:AA:AA:AA:0B is getting assigned

Expected Result:

It must throw an error instead of assigning the MAC address as AA:AA:AA:AA:AA:0B

swe12345 commented 2 years ago

@ratagupt @sunharis

swe12345 commented 2 years ago

Any update on this please?

wak-google commented 1 year ago

I believe this is working as expected with the latest code and confirmed via test case.