openbmc / phosphor-networkd

Apache License 2.0
18 stars 49 forks source link

No IPv4/IPv6 address in RedFish after certain phosphor-network commit #62

Closed Kitsok closed 1 year ago

Kitsok commented 1 year ago

After commit 59e5b91d9784274d1d99b4c10e939c38606efacc the generated Dbus tree changed from └─/xyz └─/xyz/openbmc_project └─/xyz/openbmc_project/network ├─/xyz/openbmc_project/network/config │ └─/xyz/openbmc_project/network/config/dhcp └─/xyz/openbmc_project/network/eth0 ├─/xyz/openbmc_project/network/eth0/ipv4 │ └─/xyz/openbmc_project/network/eth0/ipv4/b5383791 └─/xyz/openbmc_project/network/eth0/ipv6 ├─/xyz/openbmc_project/network/eth0/ipv6/adfb863b └─/xyz/openbmc_project/network/eth0/ipv6/b2c9a25 to -/xyz -/xyz/openbmc_project -/xyz/openbmc_project/network |-/xyz/openbmc_project/network/config |-/xyz/openbmc_project/network/dhcp -/xyz/openbmc_project/network/eth0 |-/xyz/openbmc_project/network/eth0/_310_2e2_2e254_2e245_2f11 |-/xyz/openbmc_project/network/eth0/_32a02_3a6b8_3a0_3a511_3ab62e_3a99ff_3afeb3_3a63be_2f64 -/xyz/openbmc_project/network/eth0/_66e80_3a_3ab62e_3a99ff_3afeb3_3a63be_2f64

This leads to missing IPv6 and IPv4 addresses in RedFish @ /redfish/v1/Managers/bmc/EthernetInterfaces/eth0:

{ "@odata.id": "/redfish/v1/Managers/bmc/EthernetInterfaces/eth0", "@odata.type": "#EthernetInterface.v1_6_0.EthernetInterface", "DHCPv4": { "DHCPEnabled": true, "UseDNSServers": false, "UseDomainName": false, "UseNTPServers": false }, "DHCPv6": { "OperatingMode": "Stateful", "UseDNSServers": false, "UseDomainName": false, "UseNTPServers": false }, "Description": "Management Network Interface", "FQDN": "xx-xx-xx-xx-xx-xx", "HostName": "xx-xx-xx-xx-xx-xx", "IPv4Addresses": [], "IPv4StaticAddresses": [], "IPv6AddressPolicyTable": [], "IPv6Addresses": [], "IPv6DefaultGateway": "xxxx::xxxx", "IPv6StaticAddresses": [], "Id": "eth0", "InterfaceEnabled": true, "LinkStatus": "LinkUp", "MACAddress": "xx:xx:xx:xx:xx:xx", "MTUSize": 1500, "Name": "Manager Ethernet Interface", "NameServers": [ "xx.xx.xx.xx", "xxxx::xxxx" ], "SpeedMbps": 100, "StaticNameServers": [], "Status": { "Health": "OK", "HealthRollup": "OK", "State": "Enabled" }, "VLANs": { "@odata.id": "/redfish/v1/Managers/bmc/EthernetInterfaces/eth0/VLANs" } }

williamspatrick commented 1 year ago

Are you using the latest bmcweb code also?

williamspatrick commented 1 year ago

@edtanous - Are you aware of any issues?

edtanous commented 1 year ago

Yep. The paths changed in networkd, and bmcweb needed to be updated to the new paths. Assuming folks test the code in review, this should be fixed shortly. Would be nice if folks could upstream a test for this so we make sure we have coverage.

Kitsok commented 1 year ago

Are you using the latest bmcweb code also?

Yes, I took the latest commits of both phosphor-network and bmcweb, also I've disabled all our local patches.

edtanous commented 1 year ago

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/61189

Is likely the fix you're looking for. Please test and leave comments if it solves your problem.

Kitsok commented 1 year ago

Is likely the fix you're looking for. I've tried to backport this patch to my current commits (8f7e767789a4e5da9ad218853ff6e61d395526ea for phosphor-network and fd06b304a7bdfb31e61b72376f2150b2a6e062f4 for bmcweb), the result is the same.

For now I'll better roll back phosphor-network to 55bdc36cc22cf14ae4b1778264d3855d9d16bdd6 I'm not sure if bmcweb is the only service affected by this interface change, so for me it's safer to stay on a bit outdated commit.

edtanous commented 1 year ago

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/61189 Was merged a month ago, and I haven't heard of similar failures. I suspect this bug can be closed.

sunharis commented 1 year ago

@Kitsok Can you please check and close this issue?

Kitsok commented 1 year ago

Yes. Thank you!