search

openbmc / phosphor-objmgr

Phosphor Object Manager
Apache License 2.0
6 stars 8 forks source link

Avoid introspection during discovery #11

Closed bradbishop closed 8 years ago

bradbishop commented 8 years ago

Speed up discovery by calling GetManagedObjects on any ObjectManagers. Fall back on introspection for parent elements or services that don't implement one.

This change is Reviewable

causten commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

phosphor-mapper, line 94 [r1] (raw file):

                    bool,
                    [x.attrib.get('name') for x in root.findall('node')])
                children = [

does this negate what children was on the line before?

Comments from Reviewable

bradbishop commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

phosphor-mapper, line 94 [r1] (raw file):

Previously, causten (Chris Austen) wrote… > does this negate what children was on the line before?

yes - that was the intent.

Comments from Reviewable

causten commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable