search

openbmc / phosphor-pid-control

OpenBMC PID-based Thermal Control Daemon
Apache License 2.0
16 stars 21 forks source link

FR: separate tuning and logging #10

Closed kunyi731 closed 5 years ago

kunyi731 commented 5 years ago

One of the possible thermal tuning steps is having the inner PID loop + outer PID looping all running with configurations, and observe whether the thermal setpoint is oscillating too much. In order to complete the test, phosphor-pid-control needs to log while expecting a valid setpoint is supplied.

Current -t (TuningLogging) feature assumes the set point is hard coded, but it's probably more flexible to have options that enable tuning and logging separately.

pstrinkle commented 5 years ago

When performing the tuning, typically a script is used that sets the set-point in the file to say, 6000, then after X seconds, 5000, then 7000, and tracks the fans abilities to get to that set-point -- whether they wobble too much. Driving to a thermal set-point and seeing how the configuration performs can be done via setting a margin sensor (with a setpoint) via a dbus or ipmi command.

pstrinkle commented 5 years ago

tuning vs logging separate -- easy. If I break it out - yes.