search

openbmc / phosphor-pid-control

OpenBMC PID-based Thermal Control Daemon
Apache License 2.0
16 stars 21 forks source link

If a sensor is unavailable, try again #2

Open pstrinkle opened 5 years ago

pstrinkle commented 5 years ago

Pretty much close. More like "in any case, don't fail if you can't find the the sensor, and keep trying". Note this is applicable to sensors that are unavailable.

For sensors that are expected to be treated as fault, it should trigger failsafe, and this is discussed in Ed's mail.

Putting it together, the feature request is splitted:

  1. For sensors without operation status, we can config them as optional, so they do not trigger failsafe;
  2. For sensors with operation status, do not trigger failsafe if it is unavailable; trigger failsafe if it is fault.
madscientist159 commented 4 years ago

A year and a half later, we hit the same bug...