openbmc / phosphor-pid-control

OpenBMC PID-based Thermal Control Daemon
Apache License 2.0
16 stars 21 forks source link

Add standard PID algorithm for SIE and Raptor systems #38

Closed madscientist159 closed 1 year ago

madscientist159 commented 1 year ago

The existing Google EC algorithm is not workable for the Raptor and SIE (patches coming in the future) platforms, as it is not a standard PID controller. Raptor uses standard PID controllers in its firmware, for example in its Kestrel BMC products, as after extensive testing we have found that our fan control hardware is best controlled (i.e. minimum overshoot and hunting) via a standard PID algorithm.

In this patch, the algorithm type used defaults to the Google algorithm, but can be changed in the JSON configuration file.

This is the first set of patches in a series that aims to add full support for the Raptor Computing Systems POWER9 platforms to OpenBMC.

williamspatrick commented 1 year ago

Please submit through Gerrit. We don't use github PRs.

madscientist159 commented 1 year ago

Apologies for that. Resubmitted as https://gerrit.openbmc.org/c/openbmc/phosphor-pid-control/+/64099