Use dbus active read for thermal sensors

openbmc / phosphor-pid-control

OpenBMC PID-based Thermal Control Daemon

Apache License 2.0

18 stars 21 forks source link

Use dbus active read for thermal sensors #7

Open mgersh opened 5 years ago

mgersh commented 5 years ago

Right now they're built as passive read sensors, so when the value doesn't change in a while, they go into failsafe mode.

feistjj commented 5 years ago

If this changes it needs to be configurable. We rely on this so that if a sensor stops responding it can be treated as an error and properly boost the fans.

mgersh commented 5 years ago

How are you handling the case of sensors not changing for a while? Long timeouts?

feistjj commented 5 years ago

We're using dbus-sensors project not phosphor-hwmon, I'm not sure of the behavior of phosphor-hwmon but dbus-sensors keep an async handle on the file descriptor and update the value for any change, so it hasn't been an issue yet. We also don't have any host pushed sensors.

madscientist159 commented 4 years ago

We need this option as well.