search

openbmc / phosphor-state-manager

Apache License 2.0
11 stars 21 forks source link

Non Compliance with DBUS naming conventions #1

Closed vishwabmc closed 2 years ago

vishwabmc commented 7 years ago

These names are not adhering to the DBUS naming conventions as required by : https://dbus.freedesktop.org/doc/dbus-api-design.html

AS_IF([test "x$HOST_OBJPATH" == "x"], [HOST_OBJPATH="/xyz/openbmc_project/state/host"]) AS_IF([test "x$CHASSIS_OBJPATH" == "x"], [CHASSIS_OBJPATH="/xyz/openbmc_project/state/chassis"]) AS_IF([test "x$BMC_BUSNAME" == "x"], [BMC_BUSNAME="xyz.openbmc_project.State.BMC"]) AS_IF([test "x$BMC_OBJPATH" == "x"], [BMC_OBJPATH="/xyz/openbmc_project/state/BMC"])

williamspatrick commented 7 years ago

The only one that looks wrong based on our conventions is that BMC should be lowercase in this context (for the object path).

geissonator commented 2 years ago

The object path is now lower case bmc:

root@p10bmc:/lib/systemd/system# busctl tree xyz.openbmc_project.State.BMC
`-/xyz
  `-/xyz/openbmc_project
    `-/xyz/openbmc_project/state
      `-/xyz/openbmc_project/state/bmc0